[rc-swift] ConfigContent.swift #14175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Apple API Diff ReportCommit: 7f547a3 FirebaseRemoteConfigClassesFIRRemoteConfig[ADDED] -initWithAppName:FIROptions:namespace:DBManager:configContent:analytics:Swift:
+ init ( appName : String , firOptions options : FIROptions , namespace FIRNamespace : String , dbManager DBManager : RCNConfigDBManager , configContent : RCNConfigContent , analytics : ( any FIRAnalyticsInterop )?)
Objective-C:
+ - ( nonnull instancetype ) initWithAppName :( nonnull NSString * ) appName FIROptions :( nonnull FIROptions * ) options namespace :( nonnull NSString * ) FIRNamespace DBManager :( nonnull RCNConfigDBManager * ) DBManager configContent :( nonnull RCNConfigContent * ) configContent analytics :( nullable id < FIRAnalyticsInterop > ) analytics ;[ADDED] -initWithAppName:FIROptions:namespace:DBManager:configContent:userDefaults:analytics:Swift:
+ init ( appName : String , firOptions options : FIROptions , namespace FIRNamespace : String , dbManager DBManager : RCNConfigDBManager , configContent : RCNConfigContent , userDefaults : UserDefaults ?, analytics : ( any FIRAnalyticsInterop )?)
Objective-C:
+ - ( instancetype ) initWithAppName :( NSString * ) appName FIROptions :( FIROptions * ) options namespace :( NSString * ) FIRNamespace DBManager :( RCNConfigDBManager * ) DBManager configContent :( RCNConfigContent * ) configContent userDefaults :( nullable NSUserDefaults * ) userDefaults analytics :( nullable id < FIRAnalyticsInterop > ) analytics ;[ADDED] settingsSwift:
+ var settings : RCNConfigSettings { get }
Objective-C:
+ @property ( nonatomic , readonly , strong ) RCNConfigSettings * settings |
ncooke3
approved these changes
Nov 26, 2024
Co-authored-by: Nick Cooke <[email protected]>
paulb777
added a commit
that referenced
this pull request
Dec 11, 2024
Co-authored-by: Nick Cooke <[email protected]>
paulb777
added a commit
that referenced
this pull request
Dec 11, 2024
Co-authored-by: Nick Cooke <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RCNConfigContent.[mh] -> ConfigContent.swift
Also, discovered that the multi-namespace testing in RCNRemoteConfigTest.m is thread unsafe - the updates and reads of _fetchConfig can collide with another namespace.
Working around for now by disabling multi-namespace testing. This seems to be the result of properties being atomic in ObjC but not in Swift. Adding an NSLock around _fetchConfig reads and writes doesn't work - so I'll defer this and merge it here.